Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DomCrawler] Fix Crawler::filter throw phpdoc #50555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

[DomCrawler] Fix Crawler::filter throw phpdoc #50555

merged 1 commit into from
Jun 5, 2023

Conversation

VincentLanglet
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? not really (phpdoc-fix)
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

The Crawler::filter method is calling

$converter = $this->createCssSelectorConverter();

which is throwing a LogicException since #28536

So the phpdoc should be

@throws \LogicException if the CssSelector Component is not available

and not

@throws \RuntimeException if the CssSelector Component is not available

@carsonbot carsonbot added this to the 5.4 milestone Jun 5, 2023
@fancyweb
Copy link
Contributor

fancyweb commented Jun 5, 2023

Thank you @VincentLanglet.

@fancyweb fancyweb merged commit 3336571 into symfony:5.4 Jun 5, 2023
@VincentLanglet VincentLanglet deleted the fix/phpdoc branch June 5, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
DomCrawler Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentLanglet @fancyweb @nicolas-grekas @carsonbot