Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing EN and FR translations for newest constraints #50590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Jun 7, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

</trans-unit>
<trans-unit id="105">
<source>The password strength is too low. Please use a stronger password.</source>
<target>Le mot de passe est trop fragile. Veuillez utiliser un mot de passe plus robuste.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>Le mot de passe est trop fragile. Veuillez utiliser un mot de passe plus robuste.</target>
<target>Le mot de passe est trop faible. Veuillez utiliser un mot de passe plus robuste.</target>

faible <-> robuste
fragile <-> solide

wdyt?

Copy link
Contributor

@MatTheCat MatTheCat Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took robuste from https://fr.wikipedia.org/wiki/Robustesse_d%27un_mot_de_passe and fragile from https://www.larousse.fr/dictionnaires/synonymes/robuste/18548 antonyms (it seemed to match the most).

I don’t really like faible because it has a broad meaning, but it’s just my opinion!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy that, thx for sharing :)

Copy link
Member

@nicolas-grekas nicolas-grekas Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui de ça? Ça me semble classique comme terminologie:

La force du mot de passe est trop faible. Veuillez utiliser un mot de passe plus fort.

@fancyweb
Copy link
Contributor

fancyweb commented Jun 8, 2023

This PR should target 5.4.

It looks like the translations from the NoSuspiciousCharacters constraint are completely missing, feel free to add them 😃

@fancyweb fancyweb modified the milestones: 6.3, 5.4 Jun 8, 2023
@fancyweb fancyweb removed the Bug label Jun 8, 2023
@ker0x
Copy link
Contributor Author

ker0x commented Jun 8, 2023

@fancyweb Done!

@fancyweb
Copy link
Contributor

fancyweb commented Jun 9, 2023

⚠️ It still needs to target 5.4

@nicolas-grekas
Copy link
Member

Thank you @ker0x.

@nicolas-grekas nicolas-grekas merged commit dd2f880 into symfony:5.4 Jun 9, 2023
@ker0x ker0x deleted the bugfix/validators-translations branch June 9, 2023 09:25
Neirda24 added a commit to RocIT-tech/symfony-fix-xlf-validator that referenced this pull request Jun 9, 2023
nicolas-grekas added a commit that referenced this pull request Jun 9, 2023
…lations. (Adrien Roches)

This PR was merged into the 5.4 branch.

Discussion
----------

[Translation][Validator] Fix xlf files for en & fr translations.

| Q             | A
| ------------- | ---
| Branch?       | 5.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #50618
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Fixes bug introduced in https://github.com/symfony/symfony/pull/50590/files

Commits
-------

484efb3 [Validator][Translator] Fix xlf files for en & fr translations. Bug introduced by #50590
nicolas-grekas added a commit that referenced this pull request Jun 20, 2023
* 5.4:
  [VarDumper] Dumping DateTime throws error if getTimezone is false
  Only update autoload_runtime.php when it changed
  [Intl] Update the ICU data to 73.2
  [HttpClient] Force int conversion for floated multiplier for GenericRetryStrategy
  [Validator][Translator] Fix xlf files for en & fr translations. Bug introduced by #50590
  Add missing EN and FR translations for newest constraints
nicolas-grekas added a commit that referenced this pull request Jun 21, 2023
… language (stloyd)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Validator] Add missing validator translations in Polish language

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | n/a <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->
Similar to #50590 but now in Polish language

Commits
-------

eb08ef3 [Validator] Add missing validator translations in Polish language
nicolas-grekas added a commit that referenced this pull request Jun 21, 2023
* 6.2:
  [Validator] Add missing validator translations in Polish language
  [HttpClient] Fix encoding some characters in query strings
  [SecurityBundle] Remove last usages of tag `security.remember_me_aware`
  [VarDumper] Dumping DateTime throws error if getTimezone is false
  Only update autoload_runtime.php when it changed
  [Intl] Update the ICU data to 73.2
  [HttpClient] Force int conversion for floated multiplier for GenericRetryStrategy
  [FrameworkBundle] Ignore missing directories in about command
  Revert "[Messenger] Respect `isRetryable` decision of the retry strategy when deciding if failed message should be re-delivered"
  [Validator][Translator] Fix xlf files for en & fr translations. Bug introduced by #50590
  Add missing EN and FR translations for newest constraints
nicolas-grekas added a commit that referenced this pull request Jun 21, 2023
* 6.3:
  [Validator] Add missing validator translations in Polish language
  [HttpClient] Fix encoding some characters in query strings
  [HttpKernel] make RequestPayloadValueResolver:resolve() throw on variadic argument
  [SecurityBundle] Remove last usages of tag `security.remember_me_aware`
  [VarDumper] Dumping DateTime throws error if getTimezone is false
  Only update autoload_runtime.php when it changed
  [FrameworkBundle] Fix secrets:list not displaying local vars
  [Intl] Update the ICU data to 73.2
  [DoctrineBridge] add missing UPGRADE notes for #50689
  [HttpClient] Force int conversion for floated multiplier for GenericRetryStrategy
  [Security] Fix log message in OidcTokenHandler
  Don't mark RedispatchMessage as internal
  [FrameworkBundle] Ignore missing directories in about command
  Revert "[Messenger] Respect `isRetryable` decision of the retry strategy when deciding if failed message should be re-delivered"
  [Validator] Add the `message` option to the `PasswordStrength` constraint
  [Validator][Translator] Fix xlf files for en & fr translations. Bug introduced by #50590
  CS fix
  Add missing EN and FR translations for newest constraints
  [HttpClient] Remove final keyword on AsyncResponse
  [DependencyInjection] Fix support for `false` boolean env vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants