Improve return type of getProvidedServices in ServiceProviderInterface
#50667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getProvidedServices in ServiceProviderInterface
|
To solve the issue reported by psalm for ServiceLocatorTrait, you should also improve the type of its constructor argument to say that its array of callables should be indexed by strings. |
nicolas-grekas
approved these changes
Jun 21, 2023
Yes, indeed, I first wanted to confirm that is a valid change. I will fix the rest when I have more time. |
fabpot
approved these changes
Jun 23, 2023
|
@andersonamuller Can you rebase your PR to get rid of the merge commit? Thank you. |
|
Thank you @andersonamuller. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 20, 2023
…iceLocatorTrait` (andersonamuller) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Improve type of factories in `ServiceLocatorTrait` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This describes better the shape of the array it expects. Completing this other PR #50667 Commits ------- b3d005f Improve type of factories in `ServiceLocatorTrait`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This describes better the shape of the array it returns.