-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpClient] Fix encoding some characters in query strings #50671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpClient] Fix encoding some characters in query strings #50671
Conversation
Kozzi11
commented
Jun 15, 2023
Q | A |
---|---|
Branch? | 5.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #50670 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
e35e256
to
ffc94ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the RFC is very loose on the topic, and implementations varies.
ac3f01b
to
cb26c19
Compare
Thank you @Kozzi11. |