Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpClient] Fix encoding some characters in query strings #50671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Kozzi11
Copy link

@Kozzi11 Kozzi11 commented Jun 15, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50670
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Kozzi11 Kozzi11 force-pushed the http_client_parse_rfc_compliant branch from e35e256 to ffc94ba Compare June 15, 2023 13:04
@OskarStark OskarStark changed the title [HttpClient] Fix #50670 - Make HttpClient parseUrl RFC compliant [HttpClient] Make HttpClient parseUrl RFC compliant Jun 19, 2023
@nicolas-grekas nicolas-grekas changed the title [HttpClient] Make HttpClient parseUrl RFC compliant [HttpClient] Fix encoding some characters in query strings Jun 20, 2023
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the RFC is very loose on the topic, and implementations varies.

@nicolas-grekas nicolas-grekas force-pushed the http_client_parse_rfc_compliant branch from ac3f01b to cb26c19 Compare June 21, 2023 09:50
@nicolas-grekas
Copy link
Member

Thank you @Kozzi11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants