Mark class-constants as non-deprecated #50680
Conversation
Static analysis tools like PHPStan treat the `@deprecated` flag as inherited. So when a class constant is marked as deprecated, then the same class constant in an extending class is also marked deprecated unless it gets explicitly marked as `@non-deprecated`. Without this flag PHPStan will return the message ``` Fetching deprecated class constant LAST_USERNAME of class Symfony\Bundle\SecurityBundle\Security: since Symfony 6.2, use \Symfony\Bundle\SecurityBundle\Security::LAST_USERNAME instead ``` which is not really helpful as that is exactly what one did at that point. By marking these class-constants as `@non-deprecated` PHPStan and other static analysis tools can recognize these class constants as being the rightly used ones. For more information have a look at the discussion at phpstan/phpstan-deprecation-rules#100
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.2". Cheers! Carsonbot |
|
also https://psalm.dev/r/f642da203a https://phpstan.org/r/89339c04-ac08-4f6a-b0ab-241f60670c3f 2 tools, 1 lang does not work :) |
|
I'm -1 on adding these annotations to Symfony, as they violate our phpdoc standards. Given only one tool (with an extra ruleset) uses this annotation as far as I know, this better belongs in the PHPstan stubs (as also suggested by Ondrej). But I'm +1 on deprecating these constants as well in favor of |
|
I'm closing as discussed, but I'm also looking forward to the PR that will deprecate these consts! |
Static analysis tools like PHPStan treat the
@deprecatedflag as inherited. So when a class constant is marked as deprecated, then the same class constant in an extending class is also marked deprecated unless it gets explicitly marked as@non-deprecated.Without this flag PHPStan currenlty will return the message
which is not really helpful as that is exactly what one did at that point.
By marking these class-constants as
@non-deprecatedPHPStan and other static analysis tools can recognize these class constants as being the rightly used ones.For more information have a look at the discussion at phpstan/phpstan-deprecation-rules#100