[Form] [MoneyType] Add "input" option #50720
Conversation
BASAKSemih
commented
Jun 20, 2023
•
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #50707 |
| License | MIT |
| Doc PR | - WIP |
| 'currency' => 'EUR', | ||
| 'compound' => false, | ||
| 'html5' => false, | ||
| 'scale' => 2, |
There was a problem hiding this comment.
the codestyle changes have to be reverted
| $this->assertSame(12345, $form->getData()); | ||
| } | ||
|
|
||
| public function testInputTypeIntegerAndDivisorNotEgalToOne() |
There was a problem hiding this comment.
| public function testInputTypeIntegerAndDivisorNotEgalToOne() | |
| public function testInputTypeIntegerAndDivisorNotEqualToOne() |
| public function testValueToIntegerWithSpecificOptionInputToInteger() | ||
| { | ||
| $form = $this->factory->create(static::TESTED_TYPE, null, ['input' => 'integer']); | ||
| $form->submit('12345.6'); |
There was a problem hiding this comment.
IMO this case should trigger an exception in during reverseTransform()
|
|
||
| public function testHtml5EnablesSpecificFormattingWithIntegerFormat() | ||
| { | ||
| $form = $this->factory->create(static::TESTED_TYPE, null, ['html5' => true, 'scale' => 2, 'input' => 'integer']); |
There was a problem hiding this comment.
I am not sure that a scale option with a value other than 0 plays well with how the input option is implemented currently.
But, this makes me wonder if the way this option is currently implemented actually makes sense. So maybe we should indeed allow the division to be greater than 1 and take it into account to decide whether we want to render a number or an integer widget.
There was a problem hiding this comment.
I like this feature, but I wonder about the new option name: input sounds too generic.
Just wondering: since we have other options called model_* (e.g. model_timezone in nhttps://symfony.com/doc/current/reference/forms/types/datetime.html#model-timezone). Should we rename this option to follow that pattern? Some ideas:
model_formatting
model_format
model_data_type
...
|
@BASAKSemih Do you have time to take comments into account? |
No sorry i don't have time |
|
Thank you for your answer. Let’s close for now then. Maybe someone will take over. |
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Form] add "model_type" option to MoneyType | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50707 | License | MIT This is a replacement for abandoned #50720 Please notice that the previous PR misunderstood the related issue: the intended casting should be applied when the divisor is not 1, otherwise it doesn't make sense. Commits ------- 8811741 [Form] add "model_type" option to MoneyType