Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Preserve existing Doctrine schema #50742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

[Messenger] Preserve existing Doctrine schema #50742

merged 1 commit into from
Jun 22, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 22, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no (fixing a not released bug)
New feature? no
Deprecations? no
Tickets Fix #50717
License MIT
Doc PR -

Inlining since Doctrine deprecated "toSaveSql" without providing an alternative.

Cleaning up a few unneeded calls to ORMSetup::createConfiguration() also.

@nicolas-grekas nicolas-grekas requested a review from jderusse as a code owner June 22, 2023 07:48
@carsonbot carsonbot added this to the 5.4 milestone Jun 22, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jun 22, 2023
Closed
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jun 22, 2023 •
edited
Loading

/cc @morozov @derrabus @greg0ire does that sound correct to you?

@derrabus
Copy link
Member

IIRC, the alternative to toSaveSql is to introspect only the schema assets that you actually manage before comparing it to the target schema. The rationale is that if you introspect a database with lots of tables/columns/indexes/etc although you're interested in one table only, you keep the database unnecessarily busy.

@nicolas-grekas
Copy link
Member Author

Can you help with this? I'm not fluent enough in Doctrine to turn that into code 🙈
Or is the attached patch good enough?

derrabus
derrabus approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the change will work, given that you simply inlined the method. We could iterate on this for 6.4.

@nicolas-grekas nicolas-grekas merged commit d048b8a into symfony:5.4 Jun 22, 2023
@nicolas-grekas nicolas-grekas deleted the doctrine-deprec branch June 24, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @derrabus @carsonbot