[AssetMapper] Allow DirectoryResource for cache #50749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 22, 2023
| @@ -103,6 +104,7 @@ public function testAssetConfigCacheResourceContainsDependencies() | |||
|
|
|||
| // just adding any file as an example | |||
| $mappedAsset->addFileDependency(__DIR__.'/../fixtures/importmap.php'); | |||
| $mappedAsset->addFileDependency(__DIR__.'/../fixtures/dir3'); | |||
There was a problem hiding this comment.
Should we have a addDirectoryDependency instead to make the intent more clear ?
There was a problem hiding this comment.
Perhaps - though I'm also trying to keep the patch on the smaller side.
We could merge this as-is, then think about a more generic method name like addPathDependency() for 6.4.
nicolas-grekas
approved these changes
Jun 23, 2023
fabpot
approved these changes
Jun 24, 2023
eb79228 to
d2d1476
Compare
|
Thank you @weaverryan. |
Merged
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Jun 26, 2023
…e not seen due to cache (weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle] Fixing bug where new custom controllers were not seen due to cache | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #961 | License | MIT This requires symfony/symfony#50749 Cheers! Commits ------- 4503e3d [StimulusBundle] Fixing bug where new custom controlles were not seen due to cache
symfony-splitter
pushed a commit
to symfony/stimulus-bundle
that referenced
this pull request
Jun 26, 2023
…e not seen due to cache (weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle] Fixing bug where new custom controllers were not seen due to cache | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #961 | License | MIT This requires symfony/symfony#50749 Cheers! Commits ------- 4503e3de [StimulusBundle] Fixing bug where new custom controlles were not seen due to cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In StimulusBundle, one file is dynamically generated to contain the list of custom Stimulus controllers. This means the file's contents need to be regenerated in the
devenvironment whenever a new file is added to that directory. This PR allows thefileDependenciesto also be a directory so that we can use aDirectoryResource.This may not quite fit technically as a bug fix. However, as the component is experimental, this affects the
devenvironment only and it will allow for a pretty critical bug fix in StimulusBundle, I've characterized it as a bug fix for 6.3.Thanks!