Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Fix the accessibility of some background color #50752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

#48961 is a great PR that fixes some small issues in the toolbar. However, I'm worried about one of its changes. Instead of using the custom green color defined for the toolbar, it now uses one of the green colors used in the profiler. The result is that now the profiler has a too low contrast ratio:

before

This PR restores the original green color, which looks like this:

after after-server

@fabpot
Copy link
Member

fabpot commented Jun 23, 2023

Thank you @javiereguiluz.

@fabpot fabpot merged commit 2e7e0ee into symfony:6.2 Jun 23, 2023
@javiereguiluz javiereguiluz deleted the fix_accessibility branch June 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants