[Messenger] Fix exiting messenger:failed:retry command
#50787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2627b1b to
e5ddf86
Compare
lyrixx
reviewed
Jul 5, 2023
src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php
Outdated
Show resolved
Hide resolved
e5ddf86 to
54c97a4
Compare
HypeMC
commented
Jul 11, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
HypeMC
commented
Jul 11, 2023
HypeMC
commented
Jul 11, 2023
This was referenced Jul 11, 2023
lyrixx
reviewed
Jul 12, 2023
fabpot
added a commit
that referenced
this pull request
Jul 13, 2023
…messenger:failed:retry` command (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Add missing monolog channel tag to the `messenger:failed:retry` command | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Noticed this while working on #50787, similar to #49843. Commits ------- 8f30c1e [FrameworkBundle] Add missing monolog channel tag to the `messenger:failed:retry` command
nicolas-grekas
added a commit
that referenced
this pull request
Jul 13, 2023
…hout the Console component (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DebugBundle][FrameworkBundle] Fix using the framework without the Console component | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - While working on #50787 I've noticed that it's impossible to use the framework without the Console component, event though it's an optional dependency. This PR aims to fix that. I've tested these changes on 5.4 & 6.3, however, I only made sure the container can compile. I'm not sure if there are any other gotchas. Commits ------- feddf40 [DebugBundle][FrameworkBundle] Fix using the framework without the Console component
54c97a4 to
f76fd88
Compare
@lyrixx Done |
src/Symfony/Component/Messenger/EventListener/StopWorkerOnSignalsListener.php
Outdated
Show resolved
Hide resolved
f76fd88 to
74b5ff1
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 19, 2023
…ypeMC) This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] Deprecate `StopWorkerOnSignalsListener` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - Followup to #50787. Commits ------- 0b62ce8 [Messenger] Deprecate `StopWorkerOnSignalsListener`
xabbuh
reviewed
Jul 21, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
derrabus
added a commit
that referenced
this pull request
Jul 25, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix using messenger 7.0 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Makes sure messenger v7.0 wouldn't break, see #51064 (comment). Could be update for #50787 (comment) as well. Commits ------- 9a45ae0 [FrameworkBundle] Fix using messenger 7.0
74b5ff1 to
8cf7139
Compare
8cf7139 to
5f45cef
Compare
nicolas-grekas
approved these changes
Sep 29, 2023
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
Outdated
Show resolved
Hide resolved
5f45cef to
cd6816b
Compare
|
Thank you @HypeMC. |
Merged
fabpot
added a commit
that referenced
this pull request
Oct 16, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [Messenger] Fix graceful exit | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #52077 | License | MIT My previous PR #50787 accidentally broke the behavior of the `messenger:consume` command. It no longer waits for the handler to finish, instead it exists immediately. Commits ------- b270382 [Messenger] Fix graceful exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49539 introduced a bug where it's impossible to exit the
messenger:failed:retrycommand:Ctrl+Cdoesn't work because theStopWorkerOnSignalsListenerhandles the signal but doesn't actually exit the command, so the only way to currently exit the command is to kill it by force.