Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Lock] add missing UPGRADE and CHANGELOG Lock mention #50689 #50798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Lock] add missing UPGRADE and CHANGELOG Lock mention #50689 #50798

merged 1 commit into from
Jun 28, 2023

Conversation

alli83
Copy link
Contributor

@alli83 alli83 commented Jun 27, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

$isSameDatabase parameter for DoctrineDbalStore was added in #48999.

Also related to #50689

@alli83 alli83 requested a review from jderusse as a code owner June 27, 2023 16:41
@carsonbot carsonbot added this to the 6.3 milestone Jun 27, 2023
GromNaN
GromNaN reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cross-references, it makes the review easier.

@alli83 alli83 force-pushed the lock-add-missing-upgrade-and-changelog branch from 668e5cc to 147067d Compare June 28, 2023 15:25
@alli83 alli83 mentioned this pull request Jun 28, 2023
Merged
@chalasr
Copy link
Member

chalasr commented Jun 28, 2023

@alli83 Do other classes updated by #50689 need a mention as well? If yes, can you please address them all in this PR? (It's ok for minor changes like markdown updates)

@nicolas-grekas
Copy link
Member

Thank you @alli83.

@nicolas-grekas nicolas-grekas merged commit 8871441 into symfony:6.3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@chalasr chalasr chalasr approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Lock Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alli83 @chalasr @nicolas-grekas @GromNaN @carsonbot