Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Any news on this happening? Or are any adjustments necessary?

Sorry that nobody has picked up your PR yet.

What I dislike about the proposed change is that the kernel is made aware of a specific response class and adds edge-case behavior to the request stack based on that.

From my PoV, it's totally reasonable that the request stack is empty at this point. If we've caused trouble for projects upgrading from Symfony 6.1, we need to find a solution, but I don't think we should pull this kind of logic into Symfony 7. 😕

@nicolas-grekas Can you take a look please?

Thanks for the PR and the details in the issue. I think we completely missed this consequence. It'd be fine reverting #45476, and adding also a test case that covers this situation so that we won't forget about the use case again.

@DaDeather up to submit a PR doing so?

I'm closing this one meanwhile as I agree with @derrabus, that's not the approach we should merge.

Here we go: #51391

That's the way forward, see #51391 (comment)