Issue 4911 fix #5128
Issue 4911 fix #5128
Conversation
|
This PR needs to be rebased |
|
@stof Done. |
| */ | ||
| protected function toRegex($str) | ||
| { | ||
| if ($this->isRegex($str)) { |
There was a problem hiding this comment.
return $this->isRegex($str) ? $str : '/'.preg_quote($str, '/').'/';
|
I think that Would |
|
@vicb Thanks for your suggestion. I've changed names of Do you think I should change them as well? What do you think about filter name? Currently it is |
|
Now that #4739 is merged, can you rebase this PR? |
|
@gajdaw Can you also work on another PR to implement glob support for the |
|
@fabpot PR is rebased and merged. The fix works fine for @jfsimon Can you take a look at this PR? I have added one file, i.e.: in This is a test case for a bug suggested by stof in #4911. I'm not sure but it seems that This PR passes tests on Windows. |
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7188). Commits ------- 3b2cb79 [Finder] fixed paths/notPaths regex for shell adapters 45b84c5 [Finder] fix issue 4911 Discussion ---------- [Finder] Fixes paths/notPaths issue with shell adapters This PR is built upon #5128 from @gajdaw. It fixes wrong handling of regex in `paths` and `notPaths` criteria by shell adapters. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #4911, #5128
|
Closing in favor of #7188 |
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass:
Fixes the following tickets: #4911
Todo: [list of todos pending]
License of the code: MIT
Documentation PR:
Requires #4739
I followed @fabpot suggestion: #4932 (comment)