[Security] Prevent creating session in stateless firewalls #51320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
Seb33300
commented
Aug 9, 2023
| @@ -91,7 +91,9 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio | |||
|
|
|||
| $this->logger?->debug('Authentication failure, redirect triggered.', ['failure_path' => $options['failure_path']]); | |||
|
|
|||
| $request->getSession()->set(SecurityRequestAttributes::AUTHENTICATION_ERROR, $exception); | |||
| if ($request->hasPreviousSession()) { | |||
There was a problem hiding this comment.
Better if we could check if !$options['stateless'] here, but that option is not passed
There was a problem hiding this comment.
We cannot check on $request->hasPreviousSession() this is the reason why the test is failing...
There was a problem hiding this comment.
hasPreviousSession is absolutely not the same than stateless.
There was a problem hiding this comment.
So we need a way to access the stateless option from the firewall.
If someone has an idea how to do this, please help on that. I will close that PR for now.
There was a problem hiding this comment.
@Seb33300 You can check if the _stateless attribute is set to true instead
There was a problem hiding this comment.
Good point! I modified my PR and reopened it.
There was a problem hiding this comment.
Oups cannot reopen because I force pushed...
Here is the new PR: #51350
chalasr
added a commit
that referenced
this pull request
Aug 25, 2023
… (Seb33300) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Security] Prevent creating session in stateless firewalls | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #51319 | License | MIT | Doc PR | <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Please check related issue for details. Same as #51320 with `@chalasr` suggestion: #51320 (comment) Commits ------- 4efd50e [Security] Prevent creating session in stateless firewalls
symfony-splitter
pushed a commit
to symfony/security-http
that referenced
this pull request
Aug 25, 2023
… (Seb33300) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Security] Prevent creating session in stateless firewalls | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony/symfony#51319 | License | MIT | Doc PR | <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Please check related issue for details. Same as symfony/symfony#51320 with `@chalasr` suggestion: symfony/symfony#51320 (comment) Commits ------- 4efd50e34c [Security] Prevent creating session in stateless firewalls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check related issue for details.