[Serializer] Fix deserializing object collection properties#51369
Merged
nicolas-grekas merged 1 commit intoAug 23, 2023
Merged
Conversation
06134d6 to
7ad9e6e
Compare
andersmateusz
approved these changes
Aug 19, 2023
Contributor
andersmateusz
left a comment
There was a problem hiding this comment.
Tested this on my local environment. Seems legit.
7ad9e6e to
32dc134
Compare
mtarld
approved these changes
Aug 23, 2023
Member
|
Thank you @X-Coder264. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Symfony <= 6.2 serializer versions the
supportsDenormalizationwas always called in\Symfony\Component\Serializer\Serializer::getDenormalizer.When the
getSupportedTypeslogic was introduced for Symfony 6.3 serializer someifstatement conditions were introduced and if they aretruethesupportsDenormalizationlogic is not called at all anymore. Those conditions currently prevent a legit use-case that worked prior to 6.3 from calling thesupportsDenormalizationmethod - the case being when the denormalizer is supposed to denormalize a collection/array of objects. This use-case still works even on the 6.3 serializer as long as the denormalizer does not implement the newgetSupportedTypesmethod, but that is triggering a deprecation.This PR aims to fix that so that denormalizing an array of objects still works even when using the new
getSupportedTypesmethod in a denormalizer.cc @tucksaun @nicolas-grekas