-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Fix deserializing of nested snake_case attributes using CamelCaseToSnakeCaseNameConverter #51399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Fix deserializing of nested snake_case attributes using CamelCaseToSnakeCaseNameConverter #51399
Conversation
The PR was recreated because Milestone was not appointed in PR #51394 |
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Victor-Truhanovich 🙂
Just one last thing, you should take care about fabbot errors: https://fabbot.io/report/symfony/symfony/51399/418bdea59c858a48dca18e493353454e16628aa1 |
Oh, sorry my bad, I didn't check why fabbot was yelling... Actually it's a false positive, the comments are legit here! |
@mtarld I rollbacked code style changes |
…CamelCaseToSnakeCaseNameConverter
cd65d0e
to
f114c55
Compare
Thank you @Victor-Truhanovich. |
It was not possible to deserialize nested attributes using CamelCaseToSnakeCaseNameConverter
Example