Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Do not call UserBadge->setUserLoader(UserProvider...) when the loader is already provided by AccessTokenHandler implementation #51447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kaznovac
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51446
License MIT
Doc PR N/A

restore previous behavior to fix the linked issue

99a35f0#diff-de9707bb338188f62878f2ebd42e7a7bf9547f6d0bf07a4fcd9c386c263c601bL62-R62

…en the loader is already provided by `AccessTokenHandler` implementation
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@kaznovac kaznovac changed the base branch from 6.4 to 6.3 August 21, 2023 23:30
@kaznovac
Copy link
Contributor Author

failure of Unit Tests / Unit Tests (8.1) (pull_request) is related to the PR code
https://github.com/symfony/symfony/actions/runs/5931656918/job/16083952927?pr=51447#step:8:2818

the rest seem unrelated

@guillaumesmo
Copy link
Contributor

I believe this has already been fixed by #51104

@kaznovac kaznovac closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants