[Mailer] [Smtp] Add DSN param peer_fingerprint for fingerprint verification
#51450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
peer_fingerprint for fingerprint verif…peer_fingerprint for fingerprint verif…
xdavidwu
added a commit
to xdavidwu/symfony-docs
that referenced
this pull request
Aug 22, 2023
…ication documentation for symfony/symfony#51450
xdavidwu
added a commit
to xdavidwu/symfony-docs
that referenced
this pull request
Aug 22, 2023
…ication documentation for symfony/symfony#51450
mtarld
reviewed
Aug 22, 2023
src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php
Show resolved
Hide resolved
mtarld
approved these changes
Aug 23, 2023
nicolas-grekas
approved these changes
Aug 23, 2023
src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php
Outdated
Show resolved
Hide resolved
peer_fingerprint for fingerprint verif…peer_fingerprint for fingerprint verification
d6d7635 to
a9d8431
Compare
fabpot
approved these changes
Aug 30, 2023
|
Thank you @xdavidwu. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 28, 2023
…ingerprint verification (xdavidwu) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] [Smtp] Add DSN param `peer_fingerprint` for fingerprint verification Refs * symfony/symfony#51450 Commits ------- dbfcbb1 [Mailer][Smtp] Add DSN param `peer_fingerprint` for fingerprint verification
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a more secure TLS connection for SMTP on even self-signed certificates, by verifying certificate fingerprint.