Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Fix routing to multiple fallback transports #51508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Aug 28, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
License MIT

The change made in #48121 means that it's not possible to route into multiple transport as fallback like

framework:
  messenger:
    routing:
      My\Message\*: [async, audit]

F.e. the message My\Message\ToBeSentToTwoSenders would only reach async.

The comment in the code mentions

if other senders already matched with previous types, skip the senders bound to the fallback

While in reality how it works is

if other senders already matched, skip the senders bound to the fallback

After the changes in this MR it works as mentioned in the original comment, meaning it does not skip for the same type, but routes to all transports for that type.


This is not a BC break because anyone who has more than one transport in a wildcard rule has never received anything matching the wildcard on other than the 1st transport – so only if you had a misconfiguration in the first place you're affected.

@valtzu
Copy link
Contributor Author

valtzu commented Aug 29, 2023

@wouterj Could you take a look at this when you have time, since you made the original PR?

@nicolas-grekas
Copy link
Member

Thank you @valtzu.

@nicolas-grekas nicolas-grekas merged commit 04c7ccf into symfony:6.3 Sep 29, 2023
@fabpot fabpot mentioned this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants