Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PasswordHasher] Avoid passing null to hash_pbkdf2() #51511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[PasswordHasher] Avoid passing null to hash_pbkdf2() #51511

merged 1 commit into from
Aug 29, 2023

Conversation

sdespont
Copy link
Contributor

@sdespont sdespont commented Aug 29, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Because https://www.php.net/manual/en/function.hash-pbkdf2.php is expecting string and not ?string. Pertmits avoiding deprecation warning.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "Since 5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@derrabus derrabus added Bug and removed Deprecation labels Aug 29, 2023
@derrabus derrabus modified the milestones: 6.4, 5.4 Aug 29, 2023
@carsonbot carsonbot changed the title Update Pbkdf2PasswordHasher.php [PasswordHasher] Update Pbkdf2PasswordHasher.php Aug 29, 2023
@derrabus derrabus changed the title [PasswordHasher] Update Pbkdf2PasswordHasher.php [PasswordHasher] Avoid passing null to hash_pbkdf2() Aug 29, 2023
Because https://www.php.net/manual/en/function.hash-pbkdf2.php is expecting string and not ?string. Pertmits avoiding deprecation warning.
@derrabus
Copy link
Member

Good catch, thanks @sdespont.

@derrabus derrabus merged commit fcb754a into symfony:5.4 Aug 29, 2023
This was referenced Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants