Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[AssetMapper] Allow specifying packages to update with importmap:update #51523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

[AssetMapper] Allow specifying packages to update with importmap:update #51523

merged 1 commit into from
Sep 10, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Aug 31, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Currently, the importmap:update command updates all packages.

This PR allows specifying which packages the developer wants to update.

@carsonbot carsonbot added this to the 6.4 milestone Aug 31, 2023
@jmsche
Copy link
Contributor Author

jmsche commented Aug 31, 2023

Failure of Unit Tests (8.2, low-deps) seems unrelated

stof
stof requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered by tests in the ImportMapManagerTest IMO.

weaverryan
weaverryan reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I'm happy to see how simple this is. Only a few comments related to the test

@jmsche
Copy link
Contributor Author

jmsche commented Sep 1, 2023

@weaverryan Test updated 👍

weaverryan
weaverryan approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do about pslam - it IS related, but not related to the new changes.

@jmsche
Copy link
Contributor Author

jmsche commented Sep 4, 2023 •
edited
Loading

@weaverryan Not sure either :/ Note that I only added the @return detail, it already returned this value before.

@fabpot fabpot force-pushed the importmap-update-specify-package branch from 75bc3e5 to 4d57c41 Compare September 10, 2023 08:58
@fabpot
Copy link
Member

fabpot commented Sep 10, 2023

Thank you @jmsche.

@fabpot fabpot mentioned this pull request Sep 10, 2023
Closed
@fabpot fabpot merged commit 2cfaa9d into symfony:6.4 Sep 10, 2023
@jmsche jmsche deleted the importmap-update-specify-package branch September 19, 2023 06:45
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@fabpot fabpot fabpot approved these changes

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
AssetMapper Feature Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jmsche @fabpot @weaverryan @stof @carsonbot