Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Remove GuardEvent::getContext() method without replacement#51549

Merged
fabpot merged 1 commit into
symfony:7.0from
alexandre-daubois:remove-workflow-deprec
Sep 5, 2023
Merged

[Workflow] Remove GuardEvent::getContext() method without replacement#51549
fabpot merged 1 commit into
symfony:7.0from
alexandre-daubois:remove-workflow-deprec

Conversation

@alexandre-daubois
Copy link
Copy Markdown
Member

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follow-up of #51484

@stof
Copy link
Copy Markdown
Member

stof commented Sep 4, 2023

The upgrade-7.0 file must also be updated

@alexandre-daubois
Copy link
Copy Markdown
Member Author

alexandre-daubois commented Sep 4, 2023

Actually, it has been already done last week:

symfony/UPGRADE-7.0.md

Lines 489 to 493 in d1774f4

Workflow
--------
* Require explicit argument when calling `Definition::setInitialPlaces()`
* `GuardEvent::getContext()` method has been removed. Method was not supposed to be called within guard event listeners as it always returned an empty array anyway.

@stof
Copy link
Copy Markdown
Member

stof commented Sep 4, 2023

ah OK. so this is something that has been forgotten in #51493 actually.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Sep 5, 2023

Thank you @alexandre-daubois.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants