Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CI] Make tests green again #51622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

[CI] Make tests green again #51622

merged 1 commit into from
Sep 12, 2023

Conversation

vtsykun
Copy link
Contributor

@vtsykun vtsykun commented Sep 11, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@vtsykun vtsykun requested a review from chalasr as a code owner September 11, 2023 01:08
@carsonbot carsonbot added this to the 6.4 milestone Sep 11, 2023
@vtsykun vtsykun changed the title Make tests green again [CI] Make tests green again Sep 11, 2023
@vtsykun vtsykun force-pushed the fix/tests-green branch 2 times, most recently from f3bf778 to b7114c7 Compare September 11, 2023 02:01
Nyholm
Nyholm requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. It seams to include more than "make CI green". Or am I wrong?

src/Symfony/Component/Cache/Traits/RelayProxy.php
@@ -456,6 +456,11 @@ public function bitcount($key, $start = 0, $end = -1, $by_bit = false): \Relay\R
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitcount(...\func_get_args());
}

public function bitfield($key, ...$args): \Relay\Relay|array|false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. why was this method added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test Symfony\Component\Cache\Tests\Traits\RedisProxiesTest::testRelayProxy failed after update php extension ext-relay, just I sync proxy trait with latest changes of Relay\Relay class

@vtsykun vtsykun mentioned this pull request Sep 11, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Sep 11, 2023
@nicolas-grekas
minor #51627 [Security] Fix security tests (vtsykun)
49d2527 
This PR was merged into the 6.3 branch.

Discussion
----------

[Security] Fix security tests

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Follows  #51622
| License       | MIT
| Doc PR        | -

Related to issue #51104, after it security bundle at least requires `symfony/security-http:6.3.4`  to keep the tests is green

Commits
-------

26cff6c Fix security tests
@vtsykun
Copy link
Contributor Author

vtsykun commented Sep 11, 2023

Looks like the random bug #51105 is back again.
https://github.com/symfony/symfony/actions/runs/6149268135/job/16684768491#step:8:8976

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 6.3 Sep 12, 2023
@nicolas-grekas
Copy link
Member

Thank you @vtsykun.

@nicolas-grekas nicolas-grekas merged commit 469a143 into symfony:6.4 Sep 12, 2023
@nicolas-grekas
Copy link
Member

(I cherry-picked the changes that applied to 5.4 and 6.3 respectively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@Nyholm Nyholm Nyholm requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@vtsykun @nicolas-grekas @Nyholm @derrabus @carsonbot