[FrameworkBundle] [Test] add token attributes in KernelBrowser::loginUser()
#51638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
KernelBrowser::loginUser()KernelBrowser::loginUser()
d32cc10 to
955ff13
Compare
nicolas-grekas
approved these changes
Sep 14, 2023
kbond
approved these changes
Sep 15, 2023
chalasr
approved these changes
Sep 15, 2023
a1776c0 to
1d38977
Compare
|
Thank you @Valmonzo. |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2023
…owser::loginUser()` (HeahDude) This PR was merged into the 7.0 branch. Discussion ---------- [FrameworkBundle] Remove deprecation layer for `KernelBrowser::loginUser()` | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT Follows #51638. Commits ------- 0e1d113 [FrameworkBundle] Remove deprecation layer for `KernelBrowser::loginUser()`
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an advanced use case where we define custom attributes in tokens from success handlers.
Then, we use them for access controls.
Currently we cannot define those attributes when testing and using the
loginUser()method, and so we needed to copy paste the whole logic to do it.What do you think about this feature?
I did not add tests because the method does not have any yet, should we add some?
It's my first contribution, thanks to my brother @HeahDude for his help 🙏🏽