[Scheduler] Fix stateful scheduler #51651

valtzu · 2023-09-13T20:08:20Z

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #51646, #51384
License	MIT

Stateful scheduler seems rather broken at the moment, see #51384 (comment).

Let's fix it by storing the original first run start time, that way it's always possible to recalculate the state.

Catching-up works now:

[23:14:11.709710] Worker started
[23:14:11.759318] every 2 seconds
[23:14:11.760291] every 2 seconds
[23:14:11.761257] every 2 seconds
[23:14:11.763244] every 2 seconds
[23:14:12.637054] every 2 seconds
[23:14:14.620595] every 2 seconds
[23:14:16.632170] every 2 seconds

Whereas before it would only start on from the current item, possibly skipping previous items like stated in #51646. (is this a bc break?)

I will be waiting for input from authors of the related issues.

One test is failing because because getNextRunDate is called with 2020-02-20T01:59:00+02:00 and then next run date is expected at 2020-02-20T02:09:00+02:00 but we get 2020-02-20T02:00:00+02:00 because that's set as from. I don't quite get the logic, I would assume that it is expected to be run immediately on from 🤔

fabpot

I was working on the same.
The failing test must be updated as the current one is broken and does not make sense as you already noticed.

fabpot · 2023-09-15T08:26:13Z

src/Symfony/Component/Scheduler/Trigger/PeriodicalTrigger.php

            $delta = $run->format('U.u') - $from;
            $recurrencesPassed = floor($delta / $this->intervalInSeconds);
            $nextRunTimestamp = sprintf('%.6F', ($recurrencesPassed + 1) * $this->intervalInSeconds + $from);
-            $nextRun = \DateTimeImmutable::createFromFormat('U.u', $nextRunTimestamp, $fromDate->getTimezone());
+            $nextRun = \DateTimeImmutable::createFromFormat('U.u', $nextRunTimestamp)->setTimezone($fromDate->getTimezone());


It looks like this change is not needed, is it?

From my testing, UTC is always forced in the DateTime instance when it is created from unix timestamp (timezone constructor arg has no effect), so to have the same timezone, it must be set after the instance is created.

But you are right in that this fix is not related to the issue and can/should probably be excluded here.

Can you submit another PR on 6.3 for this change then?

src/Symfony/Component/Scheduler/Generator/CheckpointInterface.php

fabpot · 2023-09-15T08:28:56Z

src/Symfony/Component/Scheduler/Trigger/PeriodicalTrigger.php

@@ -133,6 +140,6 @@ private function canBeConvertedToSeconds(\DateInterval $interval): bool

    private function calcInterval(\DateInterval $interval): float
    {
-        return $this->from->setTimestamp(0)->add($interval)->format('U.u');
+        return (new \DateTimeImmutable('@0'))->add($interval)->format('U.u');


Why do we need this change?
We might add (float) to make Psalm happy :)

I originally made this because $this->from was not always available at this point, I'm not sure if that's the case anymore

fabpot · 2023-09-15T08:47:38Z

This must be merged on 6.4 (because of the BC break, which is allowed in 6.4 for experimental components, but not for a patch release).

valtzu · 2023-09-15T08:47:58Z

I was working on the same.

@fabpot Would you like to take over this, or if you had done work on this already, discard this MR as you probably have better knowledge in this 😅

fabpot · 2023-09-15T08:49:28Z

I was working on the same.

@fabpot Would you like to take over this, or if you had done work on this already, discard this MR as you probably have better knowledge in this 😅

Actually, I like your code better, so if you take into account my few comments, I will be able to merge it fast.

valtzu · 2023-09-15T13:58:16Z

Sorry I think I misunderstood your comment @fabpot and retargeted this to 6.4 😅

The triggers have changed quite much between the 6.3&6.4 branches, but I should still target 6.3 and leave conflict resolution to someone else?

Oh my, I think I have notified everyone... sorry guys!

I will finish for today not to cause any more trouble.

fabpot · 2023-09-16T06:29:32Z

Thank you @valtzu.

…valtzu) This PR was merged into the 6.3 branch. Discussion ---------- [Scheduler] Match next run timezone with "from" timezone | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT As discussed in #51651 (comment), when a datetime object is created from unix timestamp, the timezone constructor argument is ignored as demonstrated in https://onlinephp.io/c/b07d1 and also mentioned in [PHP documentation](https://www.php.net/manual/en/datetime.construct.php#refsect1-datetime.construct-parameters): > The $timezone parameter and the current timezone are ignored when the $datetime parameter either is a UNIX timestamp (e.g. `@946684800`) or specifies a timezone (e.g. 2010-01-28T15:00:00+02:00). This change shouldn't break any existing logic, given the places where this time is used already include timezone in the date format string. ### Changes in effect ```diff ------------- ------------------------------------ --------------------------- Message Trigger Next Run ------------- ------------------------------------ --------------------------- - TestMessage PeriodicalTrigger: every 2 seconds 2023-09-16T15:54:46+00:00 + TestMessage PeriodicalTrigger: every 2 seconds 2023-09-16T18:54:46+03:00 ------------- ------------------------------------ --------------------------- ``` Commits ------- 9baf427 Match next run timezone with from timezone

valtzu requested a review from kbond as a code owner September 13, 2023 20:08

carsonbot added Status: Needs Review Bug Scheduler labels Sep 13, 2023

carsonbot added this to the 6.3 milestone Sep 13, 2023

valtzu mentioned this pull request Sep 13, 2023

[Scheduler] Intermittent Runs #51646

Closed

kbond mentioned this pull request Sep 14, 2023

[Scheduler] Caching does not work for multiple messages in same schedule #51384

Closed

fabpot requested changes Sep 15, 2023

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Sep 15, 2023

fabpot modified the milestones: 6.3, 6.4 Sep 15, 2023

Fix stateful scheduler

2d5856b

valtzu force-pushed the stateful-scheduler-bugfix branch from f761fc9 to 2d5856b Compare September 15, 2023 13:56

valtzu requested review from xabbuh, lyrixx, dunglas, yceruto, chalasr, OskarStark and jderusse as code owners September 15, 2023 13:56

carsonbot added Status: Needs Review and removed Status: Needs Work labels Sep 15, 2023

valtzu changed the base branch from 6.3 to 6.4 September 15, 2023 13:57

fabpot approved these changes Sep 15, 2023

View reviewed changes

carsonbot removed the Status: Needs Review label Sep 15, 2023

carsonbot added the Status: Reviewed label Sep 15, 2023

fabpot approved these changes Sep 16, 2023

View reviewed changes

fabpot mentioned this pull request Sep 16, 2023

[Scheduler] Fix stateful scheduler symfony/symfony-docs#18871

Closed

fabpot merged commit a90eca6 into symfony:6.4 Sep 16, 2023

valtzu mentioned this pull request Sep 16, 2023

[Scheduler] Match next run timezone with "from" timezone #51674

Merged

This was referenced Oct 21, 2023

Release v6.4.0-BETA1 #52220

Merged

Release v7.0.0-BETA1 #52224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Scheduler] Fix stateful scheduler #51651

[Scheduler] Fix stateful scheduler #51651

valtzu commented Sep 13, 2023 •

edited

Loading

fabpot left a comment

fabpot Sep 15, 2023

valtzu Sep 15, 2023 •

edited

Loading

fabpot Sep 15, 2023

fabpot Sep 15, 2023

valtzu Sep 15, 2023

fabpot commented Sep 15, 2023

valtzu commented Sep 15, 2023 •

edited

Loading

fabpot commented Sep 15, 2023

valtzu commented Sep 15, 2023 •

edited

Loading

fabpot commented Sep 16, 2023

[Scheduler] Fix stateful scheduler #51651

[Scheduler] Fix stateful scheduler #51651

Conversation

valtzu commented Sep 13, 2023 • edited Loading

fabpot left a comment

Choose a reason for hiding this comment

fabpot Sep 15, 2023

Choose a reason for hiding this comment

valtzu Sep 15, 2023 • edited Loading

Choose a reason for hiding this comment

fabpot Sep 15, 2023

Choose a reason for hiding this comment

fabpot Sep 15, 2023

Choose a reason for hiding this comment

valtzu Sep 15, 2023

Choose a reason for hiding this comment

fabpot commented Sep 15, 2023

valtzu commented Sep 15, 2023 • edited Loading

fabpot commented Sep 15, 2023

valtzu commented Sep 15, 2023 • edited Loading

fabpot commented Sep 16, 2023

valtzu commented Sep 13, 2023 •

edited

Loading

valtzu Sep 15, 2023 •

edited

Loading

valtzu commented Sep 15, 2023 •

edited

Loading

valtzu commented Sep 15, 2023 •

edited

Loading