Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix incompatibility between security-bundle 6.4 and security-http 7.0 #51672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix incompatibility between security-bundle 6.4 and security-http 7.0 #51672

merged 1 commit into from
Sep 18, 2023

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 16, 2023 •
edited
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

The security-bundle 6.4 is not compatible with security-http 7.0:

PHP Fatal error: Declaration of
Sulu\Bundle\SecurityBundle\Security\AuthenticationEntryPoint::start(
Symfony\Component\HttpFoundation\Request $request, ?Symfony\Component\Security\Core\Exception\AuthenticationException $authException = null)
must be compatible with
Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface::start(
Symfony\Component\HttpFoundation\Request $request, ?Symfony\Component\Security\Core\Exception\AuthenticationException $authException = null): Symfony\Component\HttpFoundation\Response
in /home/runner/work/sulu/sulu/src/Sulu/Bundle/SecurityBundle/Security/AuthenticationEntryPoint.php on line 25

@carsonbot carsonbot added this to the 6.4 milestone Sep 16, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@alexander-schranz alexander-schranz mentioned this pull request Sep 16, 2023
Merged
76 tasks
@alexander-schranz alexander-schranz changed the title Fix incompatibility between security-bundle 6.4 and security-http 7.0 [SecurityBundle] Fix incompatibility between security-bundle 6.4 and security-http 7.0 Sep 16, 2023
@carsonbot carsonbot changed the title [SecurityBundle] Fix incompatibility between security-bundle 6.4 and security-http 7.0 Fix incompatibility between security-bundle 6.4 and security-http 7.0 Sep 17, 2023
@derrabus
Copy link
Member

Thank you @alexander-schranz.

@derrabus derrabus merged commit 1708789 into symfony:6.4 Sep 18, 2023
@stof
Copy link
Member

stof commented Sep 18, 2023

Why is this a case where security-bundle is not compatible with security-http 7.0 ? the error message is for a class from Sulu, not for a class of symfony/security-bundle.

@derrabus
Copy link
Member

You're right, let's revert. Thanks for double-checking, @stof.

@alexander-schranz
Copy link
Contributor Author

@stof Damn missed that 🙈

@alexander-schranz alexander-schranz deleted the patch-11 branch September 18, 2023 11:06
derrabus added a commit that referenced this pull request Sep 18, 2023
@derrabus
Revert "minor #51672 Fix incompatibility between security-bundle 6.4 …
5bfce3f 
…and security-http 7.0 (alexander-schranz)"

This reverts commit 1708789, reversing
changes made to 36161f0.
@derrabus
Copy link
Member

Reverted in 5bfce3f

derrabus added a commit that referenced this pull request Sep 18, 2023
@derrabus
Merge branch '6.4' into 7.0
f3c9644 
* 6.4:
  Revert "minor #51672 Fix incompatibility between security-bundle 6.4 and security-http 7.0 (alexander-schranz)"
@alexander-schranz
Copy link
Contributor Author

Thx @derrabus, good catch @stof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexander-schranz @carsonbot @derrabus @stof