Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PasswordHasher][SecurityBundle] Fix password migration with custom hasher service with security bundle config #51686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

[PasswordHasher][SecurityBundle] Fix password migration with custom hasher service with security bundle config #51686

merged 1 commit into from
Sep 19, 2023

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Sep 18, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51670 (alternative)
License MIT
Doc PR N/A

Supersedes #51670 as a bug fix, so the security config properly uses a for the migrate_from when a MigratingPasswordHasher when a custom hasher service id is used:

security:
    password_hashers:
        legacy: md5
        App\User\Identity:
            id: App\Security\CustomHasher
            migrate_from:
                - legacy

Note
6.3 patch : 6.3...ogizanagi:63-security-custom-hasher-migrate

@ogizanagi ogizanagi requested a review from chalasr as a code owner September 18, 2023 16:23
@ogizanagi ogizanagi force-pushed the 54-security-custom-hasher-migrate branch 2 times, most recently from eb342c4 to 0d18620 Compare September 18, 2023 16:31
@ogizanagi ogizanagi force-pushed the 54-security-custom-hasher-migrate branch from 0d18620 to 4d65f30 Compare September 19, 2023 07:34
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 19, 2023
Closed
@nicolas-grekas nicolas-grekas merged commit 1de61c7 into symfony:5.4 Sep 19, 2023
@ogizanagi ogizanagi deleted the 54-security-custom-hasher-migrate branch September 19, 2023 13:57
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Sep 25, 2023
@carsonbot carsonbot changed the title [SecurityBundle][PasswordHasher] Fix password migration with custom hasher service with security bundle config [PasswordHasher][SecurityBundle] Fix password migration with custom hasher service with security bundle config Sep 25, 2023
This was referenced Sep 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug PasswordHasher SecurityBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ogizanagi @nicolas-grekas