Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PhpUnitBridge] Add some more native types #51703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

[PhpUnitBridge] Add some more native types #51703

merged 1 commit into from
Sep 25, 2023

Conversation

dylan-b-efficience-it
Copy link
Contributor

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR

stof
stof requested changes Sep 20, 2023
View reviewed changes
@nicolas-grekas nicolas-grekas changed the title [Annotations] remove phpDoc return type [PhpUnitBridge] Add native return types Sep 20, 2023
@nicolas-grekas nicolas-grekas force-pushed the phpDoc/remove-doc-return branch from 9c12f2c to 1db15fa Compare September 20, 2023 16:25
@nicolas-grekas nicolas-grekas changed the title [PhpUnitBridge] Add native return types [PhpUnitBridge] Add some more native types Sep 20, 2023
nicolas-grekas
nicolas-grekas approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've force-pushed some more native types and reverted the union ones since they're not compatible with PHP 7.2

@nicolas-grekas nicolas-grekas added this to the 7.0 milestone Sep 25, 2023
@nicolas-grekas
Copy link
Member

Thank you @d-eff-it.

@nicolas-grekas nicolas-grekas merged commit 257bdff into symfony:7.0 Sep 25, 2023
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
PhpUnitBridge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dylan-b-efficience-it @nicolas-grekas @stof