Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Ability to use transactions while sending messages with AMQP #51719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michalsitek wants to merge 11 commits into
base: 8.1
Choose a base branch
from
Open

[Messenger] Ability to use transactions while sending messages with AMQP #51719

michalsitek wants to merge 11 commits into from
+86 −0

Conversation

@michalsitek
Copy link

@michalsitek michalsitek commented Sep 22, 2023 •
edited
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #51656
License MIT
Doc PR symfony/symfony-docs#18919

stloyd
stloyd reviewed Sep 22, 2023
View reviewed changes
@michalsitek
Copy link
Author

michalsitek commented Sep 22, 2023

Tests are failing due to:

There was 1 error:

1) Symfony\Component\Finder\Tests\FinderTest::testIgnoreVCSIgnoredWithOpenBasedir
PHPUnit\Framework\Exception: PHP Warning:  file_put_contents(): open_basedir restriction in effect. File(/tmp/phpunit_MB5isx) is not within the allowed path(s): (/home/runner/work/symfony/symfony:/tmp/symfony_finder/gitignore/search_root:/tmp/deprecLc2Yrz) in Standard input code on line 92
Warning: file_put_contents(): open_basedir restriction in effect. File(/tmp/phpunit_MB5isx) is not within the allowed path(s): (/home/runner/work/symfony/symfony:/tmp/symfony_finder/gitignore/search_root:/tmp/deprecLc2Yrz) in Standard input code on line 92
PHP Warning:  file_put_contents(/tmp/phpunit_MB5isx): Failed to open stream: Operation not permitted in Standard input code on line 92
Warning: file_put_contents(/tmp/phpunit_MB5isx): Failed to open stream: Operation not permitted in Standard input code on line 92

It seems to have nothing to do with my PR.

@nicolas-grekas nicolas-grekas added this to the 6.4 milestone Sep 25, 2023
@carsonbot carsonbot changed the title [Messenger] Ability to use transactions while sending messages with AMQP Ability to use transactions while sending messages with AMQP Sep 25, 2023
@carsonbot carsonbot changed the title Ability to use transactions while sending messages with AMQP [Messenger] Ability to use transactions while sending messages with AMQP Sep 25, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@jwage jwage mentioned this pull request Apr 18, 2025
Closed
@jwage
Copy link
Contributor

jwage commented Apr 22, 2025

@michalsitek I added support for this in jwage/phpamqplib-messenger here jwage/phpamqplib-messenger#57

Could you take a look and give it a test?

OskarStark
OskarStark reviewed Apr 24, 2025
View reviewed changes
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
OskarStark
OskarStark reviewed Jun 4, 2025
View reviewed changes
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php Outdated
$confirmTimeout = ('' !== ($options['confirm_timeout'] ?? ''));

if ($transactional && $confirmTimeout) {
throw new LogicException('Confirm timeout cannot be used on transactional channel.');
Copy link
Contributor

@OskarStark OskarStark Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new LogicException('Confirm timeout cannot be used on transactional channel.');
throw new LogicException('confirm_timeout cannot be used on transactional_channel.');

?

Copy link
Author

@michalsitek michalsitek Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no transactional_channel option, just transactional, so I'll leave this part.

Copy link
Author

@michalsitek michalsitek Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the message, check now please.

@nicolas-grekas nicolas-grekas removed this from the 7.4 milestone Nov 16, 2025
@nicolas-grekas nicolas-grekas added this to the 8.1 milestone Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark left review comments

+1 more reviewer

@stloyd stloyd stloyd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Messenger

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

[Messenger] Ability to use transactions while sending messages with AMQP transport

7 participants

@michalsitek @jwage @stloyd @OskarStark @fabpot @nicolas-grekas @xabbuh