[WebProfilerBundle] make webprofiler links absolute path #51722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -537,7 +537,7 @@ if (typeof Sfjs === 'undefined' || typeof Sfjs.loadToolbar === 'undefined') { | |||
|
|
|||
| this.load( | |||
| 'sfwdt' + token, | |||
| '{{ url("_wdt", { "token": "xxxxxx" })|escape('js') }}'.replace(/xxxxxx/, newToken), | |||
| '{{ path("_wdt", { "token": "xxxxxx" })|escape('js') }}'.replace(/xxxxxx/, newToken), | |||
There was a problem hiding this comment.
isn't url() for absolute URLs and path() for relative ones? the PR title says the opposite
|
ref #37576 |
|
This breaks cases where your configure ajax requests to replace the toolbar for ajax responses and those responses from your API come from a different domain than the main document, which is exactly the use case for which we switched to absolute URLs. For your use case of proxying, the right solution IMO is to configure your proxy as a trusted proxy to make Symfony aware of the public-facing domain name to use. |
|
This PR gets a -1 vote from me. |
|
Ahh yea forgot the trusted_proxies are annoying for development, especially when you are a framework and not just a single website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a nodejs proxy to hot-reload js/css changes. The proxy url is different to the symfony url, so we replace some urls. It would make our life easier when all generated links are absolute paths (without the host).