[Messenger] Resend failed retries back to failure transport#51848
Merged
Conversation
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 / 5.4". Cheers! Carsonbot |
Contributor
|
That code goes all the way back to the original PR for the failure transport system. I can't remember why I had this, however. Since we're dealing with the failure transport, this seems like a safe area, but I'd still probably do it for 6.4. |
weaverryan
approved these changes
Oct 4, 2023
fabpot
approved these changes
Oct 5, 2023
Member
|
Thank you @ro0NL. |
This was referenced Oct 21, 2023
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Feb 25, 2024
…transport " (ro0NL) This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] Revert "Resend failed retries back to failure transport " Reverts #51848 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT See #53216, it's complex :') I suggest to get rid of confusion between `messenger:consume failed` vs. `bin/console messenger:failed:retry` somehow. cc `@beermeat` `@guelosuperstart` `@javaDeveloperKid` `@fabpot` Commits ------- 8dba632 [Messenger] Revert "Resend failed retries back to failure transport "
nicolas-grekas
added a commit
that referenced
this pull request
Feb 24, 2026
…failure transport (bartholdbos) This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] Fix re-sending failed messages to a different failure transport | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #51815 #53216 | License | MIT As explained in issue #51815 I expect messages to succeed, retry or be deleted manually. This was fixed in PR #51848 but this PR has been reverted in PR #54050 because it caused infinite re-sending as described in #53216. I added a check to prevent re-sending a failed retry to the same transport it already came from. When a different failure transport is configured it will now be sent there. Commits ------- 3b45d7a [Messenger] Fix re-sending failed messages to a different failure transport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i want to argue this is a bugfix :)
i can confirm with this fix, you can indefinitely retry failures, till they succeed, are deleted manually, or are handled explicitly by other means. What should NOT happen is systems implicitly rejecting/acking messages without any confirmation whatsoever.
cc @fabpot, @weaverryan