Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] do not access properties before initialization #51904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[HttpFoundation] do not access properties before initialization #51904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
do not access properties before initialization
  • Loading branch information
@xabbuh
xabbuh committed Oct 9, 2023
commit 6e19d1ad4e9adec858e5e69ebe06ee30eae4f713
10 changes: 7 additions & 3 deletions src/Symfony/Component/HttpFoundation/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ class Request
protected string $defaultLocale = 'en';

/**
* @var array<string, string[]>
* @var array<string, string[]>|null
*/
protected static array $formats;
protected static ?array $formats = null;

protected static ?\Closure $requestFactory = null;

Expand Down Expand Up @@ -1499,7 +1499,11 @@ public function isNoCache(): bool
*/
public function getPreferredFormat(?string $default = 'html'): ?string
{
if ($this->preferredFormat ??= $this->getRequestFormat(null)) {
if (!isset($this->preferredFormat) && null !== $preferredFormat = $this->getRequestFormat(null)) {
$this->preferredFormat = $preferredFormat;
}

if ($this->preferredFormat ?? null) {
return $this->preferredFormat;
}

Expand Down