[Workflow] Revert deprecation about Registry #51976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Oct 10, 2023
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #51662, fix #49199, fix #51400 |
| License | MIT |
This was referenced Oct 10, 2023
ro0NL
reviewed
Oct 10, 2023
OskarStark
reviewed
Oct 10, 2023
Comment on lines
-135
to
-138
| * The `Registry` is marked as internal and should not be used directly. use a tagged locator instead | ||
| ``` | ||
| tagged_locator('workflow', 'name') | ||
| ``` |
There was a problem hiding this comment.
Shouldn't we keep this? back in time in 6.2 it still is deprecated
fabpot
approved these changes
Oct 10, 2023
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 12, 2023
…olas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix registering workflow.registry | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT Forgotten in #51976 I guess /cc `@lyrixx` Commits ------- 1a74769 [FrameworkBundle] Fix registering workflow.registry
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.