Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge][TwigBridge] Add PHPDoc to attributes #51987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

squrious
Copy link
Contributor

@squrious squrious commented Oct 11, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Part of #51920
License MIT

Add PHPDoc to attributes in Symfony\Bridge\Doctrine and Symfony\Bridge\Twig.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@squrious squrious force-pushed the attributes-docs-twig-doctrine-bridges branch from 08708a8 to 947cdb9 Compare October 11, 2023 09:58
@carsonbot carsonbot changed the title Add PHPDoc to attributes [DoctrineBridge][TwigBridge] Add PHPDoc to attributes Oct 11, 2023
@squrious squrious force-pushed the attributes-docs-twig-doctrine-bridges branch 2 times, most recently from ed5154c to ac75b92 Compare October 12, 2023 11:41
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@OskarStark
Copy link
Contributor

rebased ✅

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @param annotations

@squrious
Copy link
Contributor Author

squrious commented Jan 2, 2024

Please use @param annotations

Do you mean replacing @var with @param in CPP or moving descriptions to the constructor doc block?

@OskarStark
Copy link
Contributor

Yes please move it to the constructor doc block and use @param

@squrious squrious force-pushed the attributes-docs-twig-doctrine-bridges branch from d03318d to 4732378 Compare January 2, 2024 13:31
@OskarStark OskarStark requested a review from derrabus January 2, 2024 13:48
@nicolas-grekas nicolas-grekas force-pushed the attributes-docs-twig-doctrine-bridges branch from 4732378 to d62ebc7 Compare January 5, 2024 08:20
@nicolas-grekas
Copy link
Member

Thank you @squrious.

@nicolas-grekas nicolas-grekas merged commit 4932cbe into symfony:7.1 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants