-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DoctrineBridge][TwigBridge] Add PHPDoc to attributes #51987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DoctrineBridge][TwigBridge] Add PHPDoc to attributes #51987
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
08708a8
to
947cdb9
Compare
src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntity.php
Outdated
Show resolved
Hide resolved
ed5154c
to
ac75b92
Compare
ac75b92
to
a0e2da9
Compare
rebased ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use @param
annotations
Do you mean replacing |
Yes please move it to the constructor doc block and use |
d03318d
to
4732378
Compare
4732378
to
d62ebc7
Compare
Thank you @squrious. |
Add PHPDoc to attributes in
Symfony\Bridge\Doctrine
andSymfony\Bridge\Twig
.