Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Configure logger as error logger if the Monolog Bundle is not registered #52009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

[FrameworkBundle] Configure logger as error logger if the Monolog Bundle is not registered #52009

merged 1 commit into from
Oct 12, 2023

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Oct 12, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51910
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Oct 12, 2023
@MatTheCat MatTheCat force-pushed the ticket_51910 branch 2 times, most recently from c35f20e to dc7fa89 Compare October 12, 2023 08:14
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit f06a752 into symfony:5.4 Oct 12, 2023
@MatTheCat MatTheCat deleted the ticket_51910 branch October 12, 2023 13:30
@PhilETaylor
Copy link
Contributor

PhilETaylor commented Oct 12, 2023 •
edited
Loading

hmmm - got this after composer update - remains after manually deleting caches.
ScreenShot-2023-10-12-17 40 51

ScreenShot-2023-10-12-17 38 24

@PhilETaylor
Copy link
Contributor

I should be clear, on 6.4.*

 - Downloading symfony/http-kernel (6.4.x-dev 33464ce)
  - Downloading symfony/validator (6.4.x-dev dbd0115)
  - Downloading symfony/http-foundation (6.4.x-dev 38dc0de)
  - Downloading symfony/security-http (6.4.x-dev bcf2cc2)
  - Downloading symfony/security-bundle (6.4.x-dev 8010762)
  - Downloading symfony/framework-bundle (6.4.x-dev b7abd18)
  - Downloading symfony/lock (6.4.x-dev c743cb7)
  - Downloading symfony/cache (6.4.x-dev f550e6d)
  - Downloading symfony/doctrine-bridge (6.4.x-dev f804b48)
  - Downloading friendsofphp/php-cs-fixer (v3.35.1)
  - Downloading phpstan/phpstan (1.11.x-dev 22cb9ce)
  - Upgrading symfony/http-kernel (6.4.x-dev a4425b6 => 6.4.x-dev 33464ce): Extracting archive
  - Upgrading symfony/validator (6.4.x-dev a5956e9 => 6.4.x-dev dbd0115): Extracting archive
  - Upgrading symfony/http-foundation (6.4.x-dev 688f1a9 => 6.4.x-dev 38dc0de): Extracting archive
  - Upgrading symfony/security-http (6.4.x-dev fc7a711 => 6.4.x-dev bcf2cc2): Extracting archive
  - Upgrading symfony/security-bundle (6.4.x-dev 8ba82a2 => 6.4.x-dev 8010762): Extracting archive
  - Upgrading symfony/framework-bundle (6.4.x-dev f9ee22f => 6.4.x-dev b7abd18): Extracting archive
  - Upgrading symfony/lock (6.4.x-dev b0878f1 => 6.4.x-dev c743cb7): Extracting archive
  - Upgrading symfony/cache (6.4.x-dev cf85501 => 6.4.x-dev f550e6d): Extracting archive
  - Upgrading symfony/doctrine-bridge (6.4.x-dev 1618825 => 6.4.x-dev f804b48): Extracting archive
  - Upgrading friendsofphp/php-cs-fixer (v3.35.0 => v3.35.1): Extracting archive
  - Upgrading phpstan/phpstan (1.11.x-dev 348b72e => 1.11.x-dev 22cb9ce): Extracting archive
  - ```

@MatTheCat
Copy link
Contributor Author

Seems like a rebase issue: debug.error_handler_configurator should be configured since 6.3. Ping @nicolas-grekas

@PhilETaylor
Copy link
Contributor

I can see in vendor/symfony/framework-bundle/Resources/config/debug_prod.php

ScreenShot-2023-10-12-17 52 45

and if I add dd(__FILE__) in that function, the function is being invoked.

Sorry above my internals knowledge here :)

@nicolas-grekas
Copy link
Member

PR welcome to fix this. Merging has been hard today.

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Oct 12, 2023 •
edited
Loading

PR welcome to fix this. Merging has been hard today.

I would not know what the fix is. Sorry to hear you have had a hard day with merging, Im totally not looking for support, or a speedy fix at all, just reporting what I found (I appreciate my dev-code is bleeding edge, and thus breaks often). 💰incoming :)

@nicolas-grekas
Copy link
Member

Thanks for your support!

@PhilETaylor
Copy link
Contributor

Maybe this? #52023

@PhilETaylor PhilETaylor mentioned this pull request Oct 12, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Oct 13, 2023
@nicolas-grekas
minor #52023 [FrameworkBundle] Fix merge error with `ErrorLoggerCompi…
39a56d3 
…lerPass` (PhilETaylor)

This PR was merged into the 6.3 branch.

Discussion
----------

[FrameworkBundle] Fix merge error with `ErrorLoggerCompilerPass`

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

`@nicolas`-grekas `@MatTheCat` does this make sense? If I change these 2 lines in 6.4 then my app loads fine.

relates to #52009 (comment)

This comment from `@HypeMC` #52009 (comment) guided my debugging

or am I barking up the wrong tree?

Commits
-------

0d418de Fix merge error with ErrorLoggerCompilerPass
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
@Toflar Toflar mentioned this pull request Nov 15, 2023
Closed
@oldy777 oldy777 mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@HypeMC HypeMC HypeMC left review comments

Assignees
No one assigned
Labels
FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@MatTheCat @nicolas-grekas @PhilETaylor @HypeMC @carsonbot