Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Doctrine][DoctrineBridge][HttpFoundation][VarDumper] Run tests with ORM 3 and DBAL 4 #52022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

[Doctrine][DoctrineBridge][HttpFoundation][VarDumper] Run tests with ORM 3 and DBAL 4 #52022

merged 1 commit into from
Oct 12, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Oct 12, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Follow-up to #51997
License MIT

Everything that got lost in the merge-up + a fix for the VarDumper testsuite. 😇

@carsonbot carsonbot added this to the 6.3 milestone Oct 12, 2023
@derrabus derrabus mentioned this pull request Oct 12, 2023
Closed
@carsonbot carsonbot changed the title Run tests with ORM 3 and DBAL 4 [Doctrine][DoctrineBridge][HttpFoundation] Run tests with ORM 3 and DBAL 4 Oct 12, 2023
@derrabus
Copy link
Member Author

I've opened doctrine/orm#11001 to address the deprecations reported by the CI.

@derrabus derrabus closed this Oct 12, 2023
@derrabus derrabus reopened this Oct 12, 2023
@derrabus derrabus force-pushed the bugfix/dbal-4-compat branch from 669d754 to 81c40be Compare October 12, 2023 18:46
@carsonbot carsonbot changed the title [Doctrine][DoctrineBridge][HttpFoundation] Run tests with ORM 3 and DBAL 4 [Doctrine][DoctrineBridge][HttpFoundation][VarDumper] Run tests with ORM 3 and DBAL 4 Oct 12, 2023
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit f36e4ab into symfony:6.3 Oct 12, 2023
nicolas-grekas
nicolas-grekas reviewed Oct 12, 2023
View reviewed changes
composer.json
@@ -132,7 +132,7 @@
"doctrine/collections": "^1.0|^2.0",
"doctrine/data-fixtures": "^1.1",
"doctrine/dbal": "^2.13.1|^3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add dbal v4?

@nicolas-grekas
Copy link
Member

merged up to 7.0
please let me know if we should add dbal v4 to the root composer.json

@derrabus derrabus deleted the bugfix/dbal-4-compat branch October 13, 2023 05:54
@derrabus
Copy link
Member Author

derrabus commented Oct 13, 2023 •
edited
Loading

Not on 6.x because we would lose coverage for DBAL 3. From #51997:

Right now, we should get the following test matrix:

  • same deps: DBAL 3
  • low deps: DBAL 2
  • high deps DBAL 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Doctrine DoctrineBridge HttpFoundation Status: Needs Review VarDumper
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot