[Scheduler] Add FailureEvent
#52087
Merged
[Scheduler] Add FailureEvent
#52087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd70b10 to
56f2c93
Compare
fabpot
reviewed
Oct 17, 2023
| $this->dispatcher->dispatch(new PostRunEvent($generator->getSchedule(), $context, $message)); | ||
| $this->dispatcher->dispatch(new PostRunEvent($generator->getSchedule(), $context, $message)); | ||
| } catch (\Throwable $error) { | ||
| $this->dispatcher->dispatch(new FailureEvent($generator->getSchedule(), $context, $message, $error)); |
There was a problem hiding this comment.
We need to rethrow the exception, right?
And maybe the FailureEvent can have a way to ignore the error?
There was a problem hiding this comment.
yes indeed. Maybe I could add a shouldIgnore like the one we already have for the WorkerMessageReceivedEvent
FailureEvent
329592e to
e39d744
Compare
e39d744 to
891a404
Compare
fabpot
approved these changes
Oct 17, 2023
|
Thank you @alli83. |
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #51805, It would be interesting to add a
failureEventallowing you, for instance, to remove the recurring message, depending on the error caught.