[Notifier][Sendinblue] Handle error responses without a message key #52095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 17, 2023
| @@ -65,7 +65,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e | |||
| } | |||
|
|
|||
| if (201 !== $statusCode) { | |||
| throw new HttpTransportException('Unable to send an email: '.$result['message'].sprintf(' (code %d).', $statusCode), $response); | |||
| throw new HttpTransportException('Unable to send an email: '.($error['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response); | |||
There was a problem hiding this comment.
Suggested change
| throw new HttpTransportException('Unable to send an email: '.($error['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response); | |
| throw new HttpTransportException('Unable to send an email: '.($result['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response); |
|
As Brevo is the 1:1 replacement for Sendinblue after their rebranding, can you please also update Mailer/Brevo and Notifier/Brevo bridges? Thanks |
|
@OskarStark done in #52096 as the Brevo transports only exist in the 6.4 branch, not in 5.4 |
a9fb5e5 to
8ae8993
Compare
OskarStark
approved these changes
Oct 17, 2023
|
Thank you @stof. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 17, 2023
…e key (stof) This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] [Brevo] Handle error responses without a message key | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response. This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails. This is the same change than #52095 but for the new Brevo bridge Commits ------- 517ceae Handle Brevo error responses without a message key
symfony-splitter
pushed a commit
to symfony/brevo-notifier
that referenced
this pull request
Oct 17, 2023
…e key (stof) This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] [Brevo] Handle error responses without a message key | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response. This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails. This is the same change than symfony/symfony#52095 but for the new Brevo bridge Commits ------- 517ceaea03 Handle Brevo error responses without a message key
symfony-splitter
pushed a commit
to symfony/brevo-mailer
that referenced
this pull request
Oct 17, 2023
…e key (stof) This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] [Brevo] Handle error responses without a message key | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response. This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails. This is the same change than symfony/symfony#52095 but for the new Brevo bridge Commits ------- 517ceaea03 Handle Brevo error responses without a message key
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During their outage yesterday where the endpoint returned errors with status code 500, there was no
messagekey in the json response.This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.