Fix missing dispatch WorkerStoppedEvent after SIGINT or SIGTERM
#52123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 18, 2023
| @@ -271,6 +272,8 @@ public function handleSignal(int $signal, int|false $previousExitCode = 0): int| | |||
|
|
|||
| $this->worker->stop(); | |||
|
|
|||
| $this->eventDispatcher?->dispatch(new WorkerStoppedEvent($this->worker)); | |||
There was a problem hiding this comment.
This doesn't look necessary to me. The event should already be dispatched at the end of the Worker::run() method.
There was a problem hiding this comment.
Worker::run() is not called in the case of SIGINT or SIGTERM
There was a problem hiding this comment.
Are you sure that's still the case after the fix from #52080?
There was a problem hiding this comment.
i will check that
WorkerStoppedEvent after SIGINT or SIGTERM
WorkerStoppedEvent after SIGINT or SIGTERMWorkerStoppedEvent after SIGINT or SIGTERM
|
Any news @Chris53897 ? |
|
Sorry for late response. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #52077
In my point of view this Event should be dispatched here.
But maybe there are reasons for not doing this in the past.
I am not sure if bugfix or new feature.