[HttpKernel] Introduce ExceptionEvent::isKernelTerminating() to skip error rendering when kernel is terminating
#52128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Oct 18, 2023
•
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #51912 |
| License | MIT |
Indeed I thought about it first, then I saw the kernel was accessible in the ExceptionEvent, this would have avoid an extra param. Also, it would have avoid having to think about passing both the kernel and the terminated state. I updated the PR to follow this strategy if it's preferred @nicolas-grekas |
a892f94 to
c9dfb2d
Compare
src/Symfony/Component/HttpKernel/EventListener/ErrorListener.php
Outdated
Show resolved
Hide resolved
|
Don't miss adding a line to the changelog of the component. |
Should it be in the 6.4 changelog or should I create a 7.1 one ? |
|
7.1 indeed now |
src/Symfony/Component/HttpKernel/Tests/EventListener/ErrorListenerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Tests/EventListener/ErrorListenerTest.php
Show resolved
Hide resolved
ExceptionEvent::isKernelTerminating() to skip error rendering when kernel is terminating
76d7513 to
5a1ecf8
Compare
nicolas-grekas
approved these changes
Nov 20, 2023
fabpot
approved these changes
Nov 23, 2023
…p error rendering when kernel is terminating
|
Thank you @VincentLanglet. |
OskarStark
reviewed
Nov 23, 2023
| HttpKernel | ||
| ---------- | ||
|
|
||
| * `ExceptionEvent` now takes an optional `$isKernelTerminating` parameter |
There was a problem hiding this comment.
Shouldn't we add this to the CHANGELOG instead to the upgrade guide, as this is an optional one?
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2023
…er than the upgrade files (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [HttpKernel] document added method in the changelog rather than the upgrade files | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #52128 (comment) | License | MIT Commits ------- d77db34 document added method in the changelog rather than the upgrade files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.