[WebProfilerBundle] do not install FrameworkBundle 6.4.0-BETA1
#52381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 31, 2023
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
OskarStark
approved these changes
Oct 31, 2023
|
Shall we have FrameworkBundle 6.4 conflict with WebProfilerBundle 5.4 instead? Otherwise, Composer might decide to pin WebProfilerBundle 5.4 to an old patch release. |
We have in BETA2, but we didn't have one in BETA1. Maybe we should simply conflict with BETA1? |
54a3856 to
5e68219
Compare
6.4.0-BETA1
5e68219 to
d86ec21
Compare
|
Thank you @xabbuh. |
| @@ -18,7 +18,7 @@ | |||
| "require": { | |||
| "php": ">=7.2.5", | |||
| "symfony/config": "^4.4|^5.0|^6.0", | |||
| "symfony/framework-bundle": "^5.3|^6.0", | |||
| "symfony/framework-bundle": "^5.3|^6.0,<6.4", | |||
There was a problem hiding this comment.
I updated the way the constraint is expressed, but this means the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.