Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4 or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Can you clarify what "the issue" issue is that you are trying to fix here please? Please also add a test that ensures we don't break the fixed behaviour in the future.

Can you clarify what "the issue" issue is that you are trying to fix here please? Please also add a test that ensures we don't break the fixed behaviour in the future.

The XmlEncoder in Symfony does not parse the namespace for a node without children, resulting in invalid XML when encoding. The suggested solution is to modify the XmlEncoder::parseXmlAttributes method to fetch the namespace from the node if it has one.

I cherry picked the test from

• Update XmlEncoderTest.php #52414

And added the explanation to the PR header

Your test case is failing, can you please check? Thanks

There was 1 failure:

1) Symfony\Component\Serializer\Tests\Encoder\XmlEncoderTest::testParseXmlAttributesWithNamespace
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    '@xmlns:ns' => 'http://example.com/'
     '@ns:attribute' => 'value'
+    '#' => ''
 )

/home/runner/work/symfony/symfony/src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php:412

Hey @Youngemmy5956, I didn't notice your PR and came up with the following: #52589.

Does it solve your issue?

Closing in favor of #52589