Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Add option separator to ChoiceType to use a custom separator after preferred choices #52447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Form] Add option separator to ChoiceType to use a custom separator after preferred choices #52447

merged 1 commit into from
Jan 9, 2024

Conversation

mboultoureau
Copy link
Contributor

@mboultoureau mboultoureau commented Nov 3, 2023 •
edited by OskarStark
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Linked with #52260
License MIT

Add separator_html option to display the separator text as HTML

@carsonbot carsonbot added this to the 6.4 milestone Nov 3, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@mboultoureau
Copy link
Contributor Author

The separator option is only available in the Twig template, so I've kept this behavior for this new option. Should I add them so that they're both accessible from the form builder to maintain consistency (like label / label_html and help / help_html)?

xabbuh
xabbuh requested changes Nov 4, 2023
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should indeed be a „real“ form type option.

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@mboultoureau
Copy link
Contributor Author

mboultoureau commented Dec 20, 2023 •
edited
Loading

Approved corrections

@mboultoureau mboultoureau requested a review from xabbuh December 20, 2023 09:14
xabbuh
xabbuh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a minor suggestion for the changelog

@nicolas-grekas nicolas-grekas changed the title [Form] Add separator_html option to display the separator text as HTML [Form] Add option separator to ChoiceType to use a custom separator after preferred choices Jan 9, 2024
@nicolas-grekas
Copy link
Member

Thank you @mboultoureau.

@nicolas-grekas nicolas-grekas merged commit 4328f5b into symfony:7.1 Jan 9, 2024
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 9, 2024
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 9, 2024
Closed
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mboultoureau @carsonbot @nicolas-grekas @xabbuh