Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Add webkitdirectory to FileType #52528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] Add webkitdirectory to FileType #52528

wants to merge 1 commit into from

Conversation

danielburger1337
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
License MIT

See #52493

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@danielburger1337
Copy link
Contributor Author

You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".

Branch 7.1 doesnt exit yet. Just ignore it for now?

@stof
Copy link
Member

stof commented Nov 10, 2023

This can already be configured through the attr option, so I don't think we should add this option. We generally don't add options that just get copied into attr (for instance, we removed the readonly option a long time ago due to that).

So -1 from me for now, unless convinced otherwise.

@danielburger1337
Copy link
Contributor Author

Fair point by stof. I don't care either way.

@nicolas-grekas
Copy link
Member

I was wondering if we could provide a nicer way to support upload of directories. But I never tried so I have no clue 😬

@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2023

I agree with @stof. 👎 from me

@nicolas-grekas
Copy link
Member

Thanks for submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants