[Mailer] Update default Mailjet port #52560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot
approved these changes
Nov 12, 2023
|
Thank you @Katario. |
This was referenced Nov 12, 2023
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 19, 2023
…e STARTTLS (RFreij) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS | Q | A | ------------- | --- | Branch? | 6.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT #52560 updates the default mailjet port and references the same change for mailgun. Similar to #51042 and with the same error message, the mailjet connection doesn't work now. The PR above already has a reference, but for completion sake: Ref #34846 (comment) for more explanation Commits ------- 709d56f fix(mailjet-smtp): disable tls for mailjet as it should use starttls instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #49805, update the default to 587, which is recommended by Mailjet.
Changelog is also updated accordingly.
References: