[VarExporter] Deprecate per-property lazy-initializers #52568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4909b25 to
28a78ea
Compare
|
Do you know any place where this feature has been used ? |
|
None. That's also why I'm proposing this :) |
😬 |
|
Looks like this is actually used... |
|
Here the PR to stop relying on this feature: doctrine/DoctrineBundle#1727 |
fabpot
approved these changes
Nov 14, 2023
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 14, 2023
…azy object (nicolas-grekas) This PR was merged into the 7.0 branch. Discussion ---------- [VarExporter] Drop support for partially initialized lazy object | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Sidekick of #52568 Commits ------- 27650ef [VarExporter] Drop support for partially initialized lazy object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very late deprecation for a complex feature that we'd better drop ASAP IMHO.
Property hooks should be a better solution, even thought it's still WIP.