[Console] Support ProgressBar::iterate() on empty array
#52605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Nov 15, 2023
There was a problem hiding this comment.
We could deprecate passing 0 for unknown max, but that's not necessary to fix the reported issue.
I create a branch with the deprecation, that we can discuss for 7.1: 6.4...GromNaN:symfony:issue-47259-deprecate
| @@ -195,7 +195,7 @@ public function getStartTime(): int | |||
|
|
|||
| public function getMaxSteps(): int | |||
| { | |||
| return $this->max; | |||
| return $this->max ?? 0; | |||
There was a problem hiding this comment.
$this->max can be null, but keep returning 0 for backward compatibility.
maxbeckers
approved these changes
Nov 16, 2023
Co-authored-by: Florian Reimair <[email protected]>
fabpot
approved these changes
Nov 16, 2023
|
Merging in 7.1 as this is a behavior change. |
|
Thank you @GromNaN. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #47259
Use
$max = nullto indicate that the value is unknown. This allows0to be displayed by directly setting the progress bar to 100%.Zero is only supported for
iterate(). When passed to the constructor orsetMaxSteps, it means "unknown max".