[Cache] Fix return type of Redis6Proxy::mget()
#52690
Conversation
|
We cannot widen the return type before the extension does it. The CI failures are correct. |
|
Alright, I was looking at an outdated class stub of the extension indeed. Let's close for now |
|
The in between fix might be to test for false and return [] |
|
I don't think so, because the extension cannot, currently, return false. That's the problem. So we can't test that either 😕 |
|
The extension can return false, that's the whole bug here. 🤔 |
|
It doesn't seem: https://github.com/phpredis/phpredis/blob/ff305349dba87ab857a8f28acbc3b22af5a271cc/redis.stub.php#L2178 As long as this class isn't updated, we cannot widen the return type as stated by Nicolas. Maybe I'm looking at the wrong stub however? |
|
No, that's correct, the stub is wrong, it's mentioned in the bug. :) It returns false on error even though it's not in the stub. Check the bug and the PHPRedis bug linked within. 😄 |
|
My bad, got it now 👍 Thanks for taking this time. I cannot reopen this PR, so I created this new one: #52700 |
This class is internal, the return type can be safely updated. For the record, the
falsereturn type is already added onRedis6Proxy::hmget().