Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[AssetMapper] Fix eager imports are not deduplicated #52702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2023
Merged

[AssetMapper] Fix eager imports are not deduplicated #52702

merged 1 commit into from
Nov 25, 2023

Conversation

smnandre
Copy link
Member

Q A
Branch? 6.4
Bug fix? yes ?
New feature? no
Deprecations? no
Issues Fix
License MIT

While recursively collecting eager imports, there may be duplicates.

app.js
L  A_1.js
    L B.js 
L  A_2.js
    L B.js

Removing them early avoid a lot of useless computation afterwards (and eventual side effects)

Exemple with the generated app.entrypoint.json of the Symfony UX website

  • before: 78 entries
  • after: 53 entries

@carsonbot carsonbot added this to the 7.1 milestone Nov 23, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@smnandre smnandre changed the base branch from 7.1 to 6.4 November 23, 2023 13:15
@weaverryan weaverryan modified the milestones: 7.1, 6.4 Nov 24, 2023
@weaverryan weaverryan modified the milestone: 6.4 Nov 24, 2023
@smnandre smnandre requested a review from norkunas November 25, 2023 03:08
@fabpot fabpot force-pushed the fix/assetmapper-imports-duplicated branch from bac4f07 to e76b24b Compare November 25, 2023 08:27
@fabpot
Copy link
Member

fabpot commented Nov 25, 2023

Thank you @smnandre.

@fabpot fabpot merged commit 77189f6 into symfony:6.4 Nov 25, 2023
This was referenced Nov 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@weaverryan weaverryan weaverryan approved these changes

@norkunas norkunas Awaiting requested review from norkunas

Assignees
No one assigned
Labels
AssetMapper Bug Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@smnandre @carsonbot @fabpot @weaverryan @OskarStark @norkunas