Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpClient] Allow mocking start_time info in MockResponse #52775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

[HttpClient] Allow mocking start_time info in MockResponse #52775

merged 1 commit into from
Dec 13, 2023

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Let's honor the custom start_time passed to MockResponse.

My use case is that the current behavior prevents me from easily testing code using this info.

@carsonbot carsonbot added this to the 7.1 milestone Nov 28, 2023
@fancyweb fancyweb force-pushed the http-client/allow-mocking-start-time-info branch from 3c5d797 to 944036f Compare November 28, 2023 16:19
@OskarStark OskarStark changed the title [HttpClient] Allow mocking start_time info in MockResponse [HttpClient] Allow mocking start_time info in MockResponse Nov 29, 2023
nicolas-grekas
nicolas-grekas approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog entry ;)

@fancyweb fancyweb force-pushed the http-client/allow-mocking-start-time-info branch from 944036f to 7ace621 Compare December 5, 2023 08:20
@fabpot
Copy link
Member

fabpot commented Dec 13, 2023

Thank you @fancyweb.

@fabpot fabpot merged commit 0d9562f into symfony:7.1 Dec 13, 2023
@fabpot fabpot mentioned this pull request Dec 13, 2023
Closed
@fancyweb fancyweb deleted the http-client/allow-mocking-start-time-info branch December 13, 2023 08:00
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @fabpot @nicolas-grekas @carsonbot